fix: search by UCD bugged #3147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3147 +/- ##
=======================================
Coverage 67.54% 67.54%
=======================================
Files 233 233
Lines 18492 18492
=======================================
Hits 12490 12490
Misses 6002 6002 ☔ View full report in Codecov by Sentry. |
ManonMarchand
force-pushed
the
vizier-ucd
branch
from
1be27af to
32a651d
Compare
bsipocz
approved these changes
Dec 10, 2024
|
Thanks @ManonMarchand! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi astroquery 🙂,
The search by UCD had little typos. This is now solved.
However:
This made me realize that the new version of astropy (7.0) has a stricter parser. This makes some remote tests fail with the new version. We have invalid Votables where the string "NULL" is written in integers columns instead of leaving an empty
<TD></TD>for missing values. This is fixed upstream in VizieR. The fix should be included in VizieR's next release (likely next week, otherwise early January).